Skip to content

Fixed missing read (cut/paste f'up) - #1095

Merged
dmitchell merged 2 commits into
masterfrom
dhm/asset_bug
Sep 23, 2013
Merged

Fixed missing read (cut/paste f'up)#1095
dmitchell merged 2 commits into
masterfrom
dhm/asset_bug

Conversation

@dmitchell

Copy link
Copy Markdown
Contributor

Mea culpa. Thanks @cahrens for bisecting to find.

@cahrens @chrisndodge plz review for immediate merge to fix broken master (exports w/ assets don't work)

@cahrens

cahrens commented Sep 23, 2013

Copy link
Copy Markdown

Can you check in the unit test change you made that actually hits this code?

@chrisndodge

Copy link
Copy Markdown
Contributor

+1

@cahrens

cahrens commented Sep 23, 2013

Copy link
Copy Markdown

👍 Once tests run.

dmitchell added a commit that referenced this pull request Sep 23, 2013
Fixed missing read (cut/paste f'up)
@dmitchell
dmitchell merged commit a4ee129 into master Sep 23, 2013
@gwprice gwprice mentioned this pull request Sep 23, 2013
@jzoldak
jzoldak deleted the dhm/asset_bug branch May 5, 2014 14:54
rocioar pushed a commit to open-craft/openedx-platform that referenced this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants