Auto setting of verification deadlines with manual overrides - #10912
Merged
Conversation
Contributor
Author
bderusha
force-pushed
the
bderusha/auto-deadlines-sp
branch
from
December 9, 2015 16:12
2a7f0bf to
df01ff3
Compare
bderusha
force-pushed
the
bderusha/auto-deadlines-sp
branch
from
December 9, 2015 16:59
df01ff3 to
522095e
Compare
Contributor
Author
There was a problem hiding this comment.
FYI @peter-fogg this line changed since the last time this code was reviewed. Not huge but wanted to point it out.
Contributor
There was a problem hiding this comment.
Does this code need to check expiration_datetime_is_explicit? I think the answer is no, but I just want to be sure.
Contributor
Author
There was a problem hiding this comment.
No, we only care about the expiration, not how it was set. This is good as is.
bderusha
added a commit
that referenced
this pull request
Dec 9, 2015
Auto setting of verification deadlines with manual overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.