Added staff and instructor roles on ccx to all the staff and instructors of the master course plus fixed view as student masquerade and display name of ccx on coach dashboard

[amir-qayyum-khan]

Background

fixes mitocw#126, mitocw#155 and mitocw#115

What is done in this PR

Studio Updates:

• Remove ccx from staff dashboard inside studio. Because a master course can have unlimited ccx. If we allow display of all ccx of logged in staff (who is also staff of master course ) in studio dashboard then his (staff's) dashboard can be populate with huge list of ccx along with master course

LMS Updates:

• Now when a coach creates a new ccx, I am assigning staff role on this ccx course to all staff of master course.
• Now staff of master course has staff rights on master course as well as ccx courses.
• This is for course staff to see what ccx coaches are doing with course.
• Added instructors of master course as instructor(s) in ccx.
• Note: This code will add/enrol staff and instructors in ccx and now max student limit for ccx depends on number of staff and admins.
• Fixed view as student issue on ccx, now staff can view as student and see how ccx view will appear to student
• Fixed display name on ccx coach dashboard. Previously it was show display name of master course on coach dashboard.

@pdpinch @giocalitri @pwilkins

• Staff on Master course
  
• Staff on CCX
  
• Admin/instructors on master course
  
• Admin/instructors on ccx
  

Fixed view as student

Fixed display name of ccx on coach dashboard.

[openedx-webhooks]

Thanks for the pull request, @amir-qayyum-khan! I've created OSPR-1007 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

• supporting documentation
• edx-code email threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

[pdpinch]

@amir-qayyum-khan as indicated in mitocw#126 users with the instructor/admin role need to be enrolled in the CCX as well as those with the staff role. It looks like you will need to do that explicitly.

[amir-qayyum-khan]

@pdpinch Done and rebased

[pdpinch]

@amir-qayyum-khan I've found another issue with this.

Giving master course staff access to the CCX as staff makes the CCX appear in their studio listing. Even worse, the overridden display-name isn't used.

If there's an easy way to do it, I think we should suppress the display of CCXs in the studio listing. I think that would have to be a separate PR. Can you look into this?

An alternative would be to apply the display_name override, but that would still have the issue of polluting the studio listing with potentially hundreds of CCXs.

I'm changing the title to WIP because I don't think this should be merged until this is resolved.

[amir-qayyum-khan]

Done @pdpinch

[amir-qayyum-khan]

Done @giocalitri

[doctoryes]

Nit: Extra #.

[amir-qayyum-khan]

fixed

[amir-qayyum-khan]

jenkins run js

[doctoryes]

Nit: Remove the extra coach and change to username=self.coach.username.

[doctoryes]

My first pass is complete.

@edx/devops Please review the data migration in this PR.

[pdpinch]

@amir-qayyum-khan can you add a comment(s) telling us what you've changed most recently -- or, in the future, you can add another commit so the reviewers can do a diff. If you go that route, you'd have to squash before the merge.

[amir-qayyum-khan]

@pdpinch

Oh, I squashed commits after this message https://github.com/edx/edx-platform/pull/10877#issuecomment-184751615,

• I renamed few variables in this file https://github.com/edx/edx-platform/pull/10877/files#diff-060752b618f1de90b37518736772a2cbR266
• Updated this test suit https://github.com/edx/edx-platform/pull/10877/files#diff-c309dd6446493eb28b2a3392667b55c9R65 , removed unnecessary code by incorporating CcxTestCase

[jibsheet]

👍 on the migration from DevOps

[pdpinch]

👍 from me.

@doctoryes and @giocalitri did Amir address all your concerns?

[doctoryes]

Yes - 👍

[giocalitri]

👍 also from me