Update XBlock to 0.4.4 (just a packaging change) - #10870
Conversation
e7349b9 to
52b64a1
Compare
|
@cpennington @clytwynec This was a simple change for XBlock, and then a fix for paver to not get confused. I made "paver run_pylint" use path tweaks more similar to what happens in lms/envs/common.py (etc) |
|
Oops, have to fix the hash to be a tag, one sec... :) |
44082ad to
1a5ea31
Compare
|
@doctoryes yes, I will be updating edx-platform :) |
|
Goodbye, 👍 |
There was a problem hiding this comment.
In {system}/env/common.py, do we actually include {system} in the PYTHONPATH? It looks like it includes {system}/djangoapps, but not just {system}.
There was a problem hiding this comment.
YES, good catch. I changed that, and it fixed "Unable to import 'celery.states'" violations. Now it complains about other aspects of celery, but I can fix that in another PR.
These two directories are not added to sys.path when running the application, so there is no need to add them for pylint. When they are added, they make it impossible to run pylint properly because lms.lib.xblock is imported when trying to import xblock.
1a5ea31 to
02fa9c1
Compare
|
👍 |
Update XBlock to 0.4.4 (just a packaging change)
No description provided.