Skip to content

Update XBlock to 0.4.4 (just a packaging change) - #10870

Merged
nedbat merged 2 commits into
masterfrom
ned/new-xblock
Dec 9, 2015
Merged

Update XBlock to 0.4.4 (just a packaging change)#10870
nedbat merged 2 commits into
masterfrom
ned/new-xblock

Conversation

@nedbat

@nedbat nedbat commented Dec 7, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@nedbat

nedbat commented Dec 8, 2015

Copy link
Copy Markdown
Contributor Author

@cpennington @clytwynec This was a simple change for XBlock, and then a fix for paver to not get confused. I made "paver run_pylint" use path tweaks more similar to what happens in lms/envs/common.py (etc)

@nedbat

nedbat commented Dec 8, 2015

Copy link
Copy Markdown
Contributor Author

Oops, have to fix the hash to be a tag, one sec... :)

@nedbat nedbat changed the title Update XBlock to 0.4.3 (just a packaging change) Update XBlock to 0.4.4 (just a packaging change) Dec 8, 2015
@nedbat

nedbat commented Dec 8, 2015

Copy link
Copy Markdown
Contributor Author

@doctoryes yes, I will be updating edx-platform :)

@doctoryes

Copy link
Copy Markdown
Contributor

Goodbye, -e. Weren't we planning on removing all -es at some point?

👍

Comment thread pavelib/quality.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In {system}/env/common.py, do we actually include {system} in the PYTHONPATH? It looks like it includes {system}/djangoapps, but not just {system}.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES, good catch. I changed that, and it fixed "Unable to import 'celery.states'" violations. Now it complains about other aspects of celery, but I can fix that in another PR.

These two directories are not added to sys.path when running the
application, so there is no need to add them for pylint.  When they are
added, they make it impossible to run pylint properly because
lms.lib.xblock is imported when trying to import xblock.
@clytwynec

Copy link
Copy Markdown
Contributor

👍

nedbat added a commit that referenced this pull request Dec 9, 2015
Update XBlock to 0.4.4 (just a packaging change)
@nedbat
nedbat merged commit 3603ede into master Dec 9, 2015
@nedbat
nedbat deleted the ned/new-xblock branch December 9, 2015 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants