Problem type bok choy and a11y tests - #10814
Merged
Merged
Conversation
clytwynec
force-pushed
the
clytwynec/problem-type-a11y-tests
branch
3 times, most recently
from
December 3, 2015 18:20
c1e5b56 to
57c560e
Compare
clytwynec
force-pushed
the
clytwynec/problem-type-a11y-tests
branch
3 times, most recently
from
December 7, 2015 15:56
11482f1 to
8688d0f
Compare
Contributor
There was a problem hiding this comment.
Could you update the docstring with a description of input_num?
Contributor
|
One question I have is: if there is a test failure in one of the tests, will it be easy to tell which test failed? Do we need some logging to make it obvious? |
clytwynec
force-pushed
the
clytwynec/problem-type-a11y-tests
branch
2 times, most recently
from
December 8, 2015 18:54
802234b to
5b5a2a4
Compare
clytwynec
force-pushed
the
clytwynec/problem-type-a11y-tests
branch
from
December 8, 2015 19:39
5b5a2a4 to
a9b308e
Compare
Contributor
Author
|
@benpatterson I think I've addressed the first round of comments. |
Contributor
Author
There was a problem hiding this comment.
@benpatterson I've updated this so that the user checked for in the events validation part of the tests is unique.
Contributor
|
👍 |
|
@dianakhuang this is the PR to convert the capa tests from Lettuce to Bok Choy. |
Contributor
|
This looks excellent to me. 👍 |
clytwynec
pushed a commit
that referenced
this pull request
Dec 9, 2015
Problem type bok choy and a11y tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Translates some of the problem type lettuce tests to bok choy and adds an accessibility tests for each problem type tested.
Notes
@benpatterson Please review. (I"m still figuring out a second reviewer.)