Using edx-django-oauth2-provider from PyPI

[clintonb]

• Uninstalling old package
• Using package from PyPI

Related to edx/django-oauth2-provider#21.

[clintonb]

jenkins run all

[clintonb]

@nedbat @edx/devops please review

FYI @justinabrahms @nasthagiri @edx/ecommerce

[justinabrahms]

Given you're only using frozen to check for contents, it seems easier to not do splitlines, but get it back as a full string. That way you can do "{}==".format(package) in frozen which seems easier in a big string, rather than iterating over a list of strings.

[clintonb]

Updated.

[jimabramson]

@clintonb note that edx-oauth2-provider has this package as a direct dependency. I guess that is a separate problem but we need the dependencies to match.

[justinabrahms]

Looks pretty good from my perspective. :)

[clintonb]

Thanks for the heads-up @jimabramson. See edx/edx-oauth2-provider#33. I will update this code shortly to only use edx-oauth2-provider. I'm not sure why we are installing PyJWT or django-oauth2-provider separately.

[jimabramson]

@clintonb I think, unfortunately, that edx-platform accesses some of that stuff directly.

[clintonb]

@jimabramson I have confirmed that all direct uses are test-related. We don't seem to be using either package outside of the intended scope (in conjunction with edx-oauth2-provider), so this is a fairly safe change.

[jimabramson]

👍 but the accessibility failures look real.

[nedbat]

This doesn't do the same thing as the original code, because edxval was installed with -e, and so wouldn't be found by this new code. It's probably a moot point now, since people have had to make new devstacks for 1.8 anyway, but we should get a more robust technique here...

[clintonb]

Based on your statements, it sounds like this code is no longer needed. If I updated it to simply remove django-oauth2-provider, would that be okay?

[nedbat]

In theory we don't need to uninstall the other packages any more. I'm not a fan of getting rid of them just because we borked the code, though.

Also, you need to change the expected_version from 2 to 3 so that the uninstall will run at all.

[nedbat]

After I wrote the last comment, there's a developer in the Dev hipchat channel with a South failure. Not sure why, but these installations persist...

[rlucioni]

@clintonb @jimabramson jumping in to note that https://github.com/edx/edx-platform/pull/10701 introduces direct use of PyJWT, separate from edx-oauth2-provider.

[feanil]

@clintonb currently we don't run this as a part of building AMIs so either AMIs will need to be built from scratch or there will need to be a corresponding configuration change to run this command as a part of building the edxapp AMIs.

[clintonb]

@feanil is there any cost to building from scratch aside from time?