Skip to content

Add instructions to github.txt - #10730

Merged
nedbat merged 1 commit into
masterfrom
ned/github-txt-instructions
Nov 25, 2015
Merged

Add instructions to github.txt#10730
nedbat merged 1 commit into
masterfrom
ned/github-txt-instructions

Conversation

@nedbat

@nedbat nedbat commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@nedbat

nedbat commented Nov 24, 2015

Copy link
Copy Markdown
Contributor Author

@doctoryes @macdiesel @cpennington @jcdyer @dan-f @clintonb @feanil I think I've talked with each of you about bits of this. Feedback welcome: how can I make this clearer?

@clintonb

Copy link
Copy Markdown
Contributor

👍

Comment thread requirements/edx/github.txt Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably letting VERSION=0.0 reach master would be a Bad Idea(TM), as it would force everyone to reinstall every single time. Maybe include a note to this effect?

@doctoryes

Copy link
Copy Markdown
Contributor

Excellent guidance! 👍

@macdiesel

Copy link
Copy Markdown
Contributor

I like this a lot.
👍
🐐

@nedbat
nedbat force-pushed the ned/github-txt-instructions branch from 6c62d6d to fc875b1 Compare November 24, 2015 21:25
@nedbat

nedbat commented Nov 24, 2015

Copy link
Copy Markdown
Contributor Author

@jcdyer good points, I've added a bit to deal with both of them.

@feanil

feanil commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@jcdyer

jcdyer commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

👍

@dan-f

dan-f commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

@nedbat I am also curious about the "don't use -e" rule.

@nedbat

nedbat commented Nov 24, 2015

Copy link
Copy Markdown
Contributor Author

@dan-f I resisted putting in all the reasons. -e lets us be lazy and get our setup.py files wrong. We'd rather not get them wrong. Forbidding -e means that when we write the setup.py, it will get used fully, and we will find out about problems sooner.

nedbat added a commit that referenced this pull request Nov 25, 2015
@nedbat
nedbat merged commit ae50d4d into master Nov 25, 2015
@nedbat
nedbat deleted the ned/github-txt-instructions branch November 25, 2015 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants