Add a Studio view and template to host the Programs authoring app - #10714
Conversation
5ce4163 to
e2a618d
Compare
|
This is still a WIP, but here's a proof of concept: That page is served at http://localhost:8001/program/1. There are a handful of issues that need ironing out (e.g., styling, run keys and dates don't appear, Programs API must allow CORS). |
e2a618d to
15c1f7b
Compare
|
@cahrens and @explorerleslie, although this PR represents work that's still in progress, the finished version will benefit from a T&L review. It's related to https://github.com/edx/edx-platform/pull/10701, where @andy-armstrong was very helpful. |
|
Thanks for the heads-up @rlucioni. I created https://openedx.atlassian.net/browse/TNL-3854 for the TNL review. Do you have an estimate of when this will be ready? Note that if you are adding a new menu item, there is some CSS you have to add to make the menu item the correct color on hover. See #9029. |
|
@cahrens this will most likely be ready for review tomorrow morning. |
|
Before TNL reviews, we would like a full review by a member of your team (and tests and all should be present). We are starting a new sprint on Thursday, so we should be able to include the review in our next sprint. What is your deadline? |
c86e4aa to
0e39959
Compare
rlucioni
changed the title
|
@jimabramson this is ready for review. Could you please take a look when you have a moment? |
|
@peter-fogg could you please be the second reviewer on this? |
0e39959 to
d6f3a35
Compare
There was a problem hiding this comment.
I don't think you want the * here -- leaving the trailing slash with no $ will match the URLs you want.
|
👍 LGTM, though two Bok Choy tests are failing. Could it be an issue with |
|
@peter-fogg I've resolved the bokchoy failures. They were due to changes I made to the Studio index page template not being reflected by the bokchoy tests. |
d6f3a35 to
529e3b7
Compare
There was a problem hiding this comment.
minor: would it be better to reverse the url in the view and pass it with template context?
There was a problem hiding this comment.
Yes, that's cleaner and consistent with what I'm doing in the ProgramAuthoringView. Updated.
|
this looks good to me, with one nitpick that is not a blocker on my end. 👍 |
The Programs authoring app is a Backbone SPA maintained in a separate repository. The app handles its own routing and provides a UI which can be used to create and publish new Programs (e.g, XSeries). ECOM-2598.
529e3b7 to
e2833d8
Compare
|
👍 |
Add a Studio view and template to host the Programs authoring app
4 participants
Requires changes from https://github.com/edx/edx-platform/pull/10701.
FYI @jimabramson @AlasdairSwan