Skip to content

SOL-1390: Cert Exceptions: View and Edit Exception list - #10656

Merged
ziafazal merged 1 commit into
masterfrom
saleem-latif/SOL-1390
Nov 25, 2015
Merged

SOL-1390: Cert Exceptions: View and Edit Exception list#10656
ziafazal merged 1 commit into
masterfrom
saleem-latif/SOL-1390

Conversation

@saleem-latif

Copy link
Copy Markdown
Contributor

Hi @ziafazal , @asadiqbal08 ,

Kindly review this PR, it contains changes for SOL-1390,

Description of SOL-1390:
Background
There is currently no way to view the exception list or remove a user from exception list, it would be good to have the ability to remove user from exception list.
Acceptance Criteria

  1. In the Certificate Exception section of the Certificates tab on the Instructor Dashboard: Add a table view of all exceptions added to the course:
    Username, Email address, Date Added, Notes
  2. Add a "Remove from List" button that allows the PM user to remove a user from the exceptions list.
    If the system has already generated a certificate for a user that we'd like to remove from the list, invalidate that certificate

DESIGN NOTES:
Add the list of users who have been granted exceptions BELOW the Generate Exception Certificate button

cc; @mattdrayer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this CertificateWhitelistFactory call required in this test scenario?

@saleem-latif

Copy link
Copy Markdown
Contributor Author

@ziafazal , @asadiqbal08 I have incorporated your feedback, kindly take a look.

Comment thread lms/djangoapps/instructor/views/api.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of this method does not reflect the operations it is doing. May be we can rename it to parse_and_get_user or split this in to two methods one which parses user data and other one fetch user object.

@saleem-latif
saleem-latif force-pushed the saleem-latif/SOL-1390 branch 2 times, most recently from aa50e0b to 9220fcb Compare November 20, 2015 05:22
@saleem-latif

Copy link
Copy Markdown
Contributor Author

@ziafazal , @asadiqbal08 I have incorporated the feedback, kindly take a look. After the review, I will rebase the branch with master resolve conflicts.

@ziafazal

Copy link
Copy Markdown
Contributor

@saleem-latif LGTM 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saleem-latif We should check for student enrollment in course as well, I think this code will push the user in white-list without checking his/her enrollment in the course.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asadiqbal08 This has been incorporated with SOL-1389.

@asadiqbal08

Copy link
Copy Markdown
Contributor

@saleem-latif beside the above comment, These changes are looking good to me. 👍
kindly resolve the conflicts for this PR.

ziafazal added a commit that referenced this pull request Nov 25, 2015
SOL-1390: Cert Exceptions: View and Edit Exception list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants