SOL-1390: Cert Exceptions: View and Edit Exception list - #10656
Conversation
There was a problem hiding this comment.
Is this CertificateWhitelistFactory call required in this test scenario?
a9663b5 to
ffaef01
Compare
|
@ziafazal , @asadiqbal08 I have incorporated your feedback, kindly take a look. |
There was a problem hiding this comment.
Name of this method does not reflect the operations it is doing. May be we can rename it to parse_and_get_user or split this in to two methods one which parses user data and other one fetch user object.
aa50e0b to
9220fcb
Compare
|
@ziafazal , @asadiqbal08 I have incorporated the feedback, kindly take a look. After the review, I will rebase the branch with master resolve conflicts. |
|
@saleem-latif LGTM 👍 |
9220fcb to
f47fa69
Compare
There was a problem hiding this comment.
@saleem-latif We should check for student enrollment in course as well, I think this code will push the user in white-list without checking his/her enrollment in the course.
There was a problem hiding this comment.
@asadiqbal08 This has been incorporated with SOL-1389.
|
@saleem-latif beside the above comment, These changes are looking good to me. 👍 |
f47fa69 to
764ceb0
Compare
SOL-1390: Cert Exceptions: View and Edit Exception list
Hi @ziafazal , @asadiqbal08 ,
Kindly review this PR, it contains changes for SOL-1390,
Description of SOL-1390:
Background
There is currently no way to view the exception list or remove a user from exception list, it would be good to have the ability to remove user from exception list.
Acceptance Criteria
Username, Email address, Date Added, Notes
If the system has already generated a certificate for a user that we'd like to remove from the list, invalidate that certificate
DESIGN NOTES:
Add the list of users who have been granted exceptions BELOW the Generate Exception Certificate button
cc; @mattdrayer