Rewrote Credit API - #10634
Merged
Merged
Conversation
clintonb
commented
Nov 16, 2015
clintonb
commented
Contributor
- Rewrote Credit API using Django REST Framework.
- Added support for OAuth 2.0 and session authentication
- Added permissions
clintonb
force-pushed
the
clintonb/credit-api-drf
branch
from
November 16, 2015 05:37
7d20a12 to
db2dff9
Compare
clintonb
force-pushed
the
clintonb/credit-api-drf
branch
2 times, most recently
from
November 16, 2015 19:51
f7e12e4 to
19dec28
Compare
Contributor
Author
|
Please review @bderusha and @peter-fogg. |
Contributor
There was a problem hiding this comment.
For my own edification, why are we removing the feature flag? Was it used before?
Contributor
Author
There was a problem hiding this comment.
It was used, but it isn't really needed. If we don't want to use the Credit API...don't use it. Additionally, the feature is fully rolled-out. The odds of us disabling this API are quite low.
clintonb
force-pushed
the
clintonb/credit-api-drf
branch
from
November 16, 2015 20:56
19dec28 to
568015a
Compare
Contributor
There was a problem hiding this comment.
can we just use a full name variable here instead of initials and get rid of this pylint comment
Contributor
|
👍 Take it to mergetown, nice work. |
Contributor
|
Couple pretty minor comments. Respond/address and 👍 from me |
clintonb
force-pushed
the
clintonb/credit-api-drf
branch
3 times, most recently
from
November 17, 2015 16:37
5dd8f46 to
900a66d
Compare
Contributor
Author
|
jenkins run lettuce |
clintonb
force-pushed
the
clintonb/credit-api-drf
branch
4 times, most recently
from
November 19, 2015 20:50
5101fea to
0e3791c
Compare
Contributor
Author
|
jenkins run js |
- API built atop Django REST Framework - Added support for OAuth 2.0 and session authentication - Added permissions around eligibility data ECOM-2609
clintonb
force-pushed
the
clintonb/credit-api-drf
branch
from
November 25, 2015 03:07
0e3791c to
9215375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.