Skip to content

Turn Locations into dicts less often - #1061

Merged
cpennington merged 1 commit into
openedx:masterfrom
cpennington:faster-location-urls
Sep 23, 2013
Merged

Turn Locations into dicts less often#1061
cpennington merged 1 commit into
openedx:masterfrom
cpennington:faster-location-urls

Conversation

@cpennington

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url = "{0.tag}://{0.org}/{0.course}/{0.category}/{0.name}".format(self)

@nedbat

nedbat commented Sep 23, 2013

Copy link
Copy Markdown
Contributor

👍

cpennington added a commit that referenced this pull request Sep 23, 2013
@cpennington
cpennington merged commit 25ea91e into openedx:master Sep 23, 2013
@cpennington
cpennington deleted the faster-location-urls branch September 23, 2013 18:55
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
Missing course_id filter for certificate summary
afzaledx pushed a commit to open-craft/openedx-platform that referenced this pull request Jun 1, 2018
YONK-924: Oauth2 authentication on Xblock API handlers
iloveagent57 pushed a commit that referenced this pull request Feb 26, 2024
Change provision-ida.sh so that on provision it imports environmental
variables like:

- DEVSTACK_WORKSPACE
- COMPOSE_PROJECT_NAME
- COMPOSE_PATH_SEPARATOR
- COMPOSE_FILE

that are defined in Makefile and options.mk.

Before this change, provision would re-create a devstack container that
was not mapped to the user's local machine using COMPOSE_FILE here:

https://github.com/openedx/devstack/blob/fac68ae85b49cc6186d4872c0f3e2bfbc64f98db/provision-ida.sh#L12

Then fail on requirements gathering for course-discovery here:

https://github.com/openedx/devstack/blob/fac68ae85b49cc6186d4872c0f3e2bfbc64f98db/provision-ida.sh#L15

Due to:

- Outdated BASIC authentication credentials provided by the configuration
  repository by default in our devstack images, and

- Not having the user's .git/config file for the repo mapped into the
  container.

Co-authored-by: Alexander Sheehan <asheehan@edx.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants