-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate PublishableEntities with Collections [FC-0062] #216
Merged
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 534e8d9 - Browse repository at this point
Copy the full SHA 534e8d9View commit details -
feat: adds CollectionObject model and APIs
to associate PublishableEntities with Collections. Collection.modified timestamp is updated whenever its contents are changed.
Configuration menu - View commit details
-
Copy full SHA for 1fda3e5 - Browse repository at this point
Copy the full SHA 1fda3e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2cd234 - Browse repository at this point
Copy the full SHA a2cd234View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ec9ba5 - Browse repository at this point
Copy the full SHA 7ec9ba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e15dd0 - Browse repository at this point
Copy the full SHA 0e15dd0View commit details
Commits on Aug 29, 2024
-
refactor: use "entities" instead of "contents" or "objects"
Addresses PR review. * CollectionObject -> CollectionPublishableEntity, with added created_by and created fields * contents -> entities, contents_qset -> entities_qset * get_object_collections -> get_entity_collections, with added learning_package_id argument
Configuration menu - View commit details
-
Copy full SHA for 00111bc - Browse repository at this point
Copy the full SHA 00111bcView commit details -
refactor: merge get_collections + get_learning_package_collections
We ended up not needing a "get all collections" function; we always fetch them for a given learning package. So we merged them into a single api.get_collections method that takes a `learning_package_id` + optional `enabled` (defaults to True).
Configuration menu - View commit details
-
Copy full SHA for b723d79 - Browse repository at this point
Copy the full SHA b723d79View commit details
Commits on Aug 30, 2024
-
API: * create_collection -- removed entities_qset param, added enabled param * add/remove entities from a single collection, not a qset * raise ValidationError if adding entities to a collection with mismatching learning packages * add/remove returns updated collection object (not count) Tests: * use authoring API * simplified data used by test classes
Configuration menu - View commit details
-
Copy full SHA for 2fe2e70 - Browse repository at this point
Copy the full SHA 2fe2e70View commit details
Commits on Sep 3, 2024
-
fix: use fewer queries to discover invalid entities
being added to a collection
Configuration menu - View commit details
-
Copy full SHA for e03daaa - Browse repository at this point
Copy the full SHA e03daaaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.