Skip to content

refactor: change dashboard/course about exceptions naming for clarity #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariajgrimaldi merged 1 commit into from
May 5, 2022
Merged

refactor: change dashboard/course about exceptions naming for clarity #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,19 @@ Change Log
in this file. It adheres to the structure of https://keepachangelog.com/ ,
but in reStructuredText instead of Markdown (for ease of incorporation into
Sphinx documentation and the PyPI description).

This project adheres to Semantic Versioning (https://semver.org/).

.. There should always be an "Unreleased" section for changes pending release.

Unreleased
~~~~~~~~~~

[0.6.2] - 2022-04-07
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Change dashboard/course about render exceptions naming for clarity

[0.6.1] - 2022-04-07
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down
4 changes: 2 additions & 2 deletions openedx_filters/learning/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def __init__(self, message, redirect_to=""):
"""
super().__init__(message, redirect_to=redirect_to)

class RenderAlternativeCourseAbout(OpenEdxFilterException):
class RenderInvalidCourseAbout(OpenEdxFilterException):
"""
Custom class used to stop the course about rendering process.
"""
Expand Down Expand Up @@ -348,7 +348,7 @@ def __init__(self, message, redirect_to=""):
"""
super().__init__(message, redirect_to=redirect_to)

class RenderAlternativeDashboard(OpenEdxFilterException):
class RenderInvalidDashboard(OpenEdxFilterException):
"""
Custom class used to stop the dashboard render process.
"""
Expand Down
4 changes: 2 additions & 2 deletions openedx_filters/learning/tests/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def test_dashboard_render_started(self):
@data(
(DashboardRenderStarted.RedirectToPage, {"redirect_to": "custom-dashboard.html"}),
(
DashboardRenderStarted.RenderAlternativeDashboard,
DashboardRenderStarted.RenderInvalidDashboard,
{
"dashboard_template": "custom-dasboard.html",
"template_context": {"user": Mock()},
Expand All @@ -333,7 +333,7 @@ def test_halt_dashboard_render(self, dashboard_exception, attributes):
@data(
(CourseAboutRenderStarted.RedirectToPage, {"redirect_to": "custom-course-about.html"}),
(
CourseAboutRenderStarted.RenderAlternativeCourseAbout,
CourseAboutRenderStarted.RenderInvalidCourseAbout,
{
"course_about_template": "custom-course-about.html",
"template_context": {"course_id": Mock()},
Expand Down