test: add test cases for each filter definition - #29
Merged
Conversation
mariajgrimaldi
force-pushed
the
MJG/improve-coverage
branch
2 times, most recently
from
April 1, 2022 00:35
14b3c2a to
ddbc339
Compare
mariajgrimaldi
marked this pull request as ready for review
April 1, 2022 00:37
mariajgrimaldi
force-pushed
the
MJG/improve-coverage
branch
from
April 1, 2022 00:38
ddbc339 to
2b3beda
Compare
Member
Author
|
Hi there @felipemontoya! This PR increases coverage by adding tests for filters definition. I believe this is why we need to merge #26 |
mariajgrimaldi
force-pushed
the
MJG/improve-coverage
branch
from
April 1, 2022 14:57
2b3beda to
45fe8c0
Compare
felipemontoya
approved these changes
Apr 1, 2022
Member
|
This is good, back to 100% |
mariajgrimaldi
force-pushed
the
MJG/improve-coverage
branch
from
April 1, 2022 16:46
45fe8c0 to
272f486
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds test suites for each filter definition implemented so far.
Testing instructions:
Run
make test-allReviewers:
Merge checklist: