Skip to content

Remove Taxonomy.required, make allow_multiple True by default [FC-0030] #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 3 commits into from
Oct 6, 2023
Merged

Remove Taxonomy.required, make allow_multiple True by default [FC-0030] #91

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47d3822
feat: remove language fixture, Taxonomy.required, make allow_multiple…
bradenmacdonald Oct 3, 2023
416f0f5
fix: consistency fix from PR review
bradenmacdonald Oct 6, 2023
45c2f1f
chore: version bump
bradenmacdonald Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions openedx_tagging/core/tagging/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def create_taxonomy(
name: str,
description: str | None = None,
enabled=True,
required=False,
allow_multiple=False,
Comment thread
bradenmacdonald marked this conversation as resolved.
Outdated
allow_free_text=False,
taxonomy_class: type[Taxonomy] | None = None,
Expand All @@ -38,7 +37,6 @@ def create_taxonomy(
name=name,
description=description or "",
enabled=enabled,
required=required,
allow_multiple=allow_multiple,
allow_free_text=allow_free_text,
)
Expand Down Expand Up @@ -213,11 +211,6 @@ def _check_new_tag_count(new_tag_count: int) -> None:
if not taxonomy.allow_multiple and len(tags) > 1:
raise ValueError(_(f"Taxonomy ({taxonomy.name}) only allows one tag per object."))

if taxonomy.required and len(tags) == 0:
raise ValueError(
_(f"Taxonomy ({taxonomy.id}) requires at least one tag per object.")
)

current_tags = list(
ObjectTagClass.objects.filter(taxonomy=taxonomy, object_id=object_id)
)
Expand Down
Loading