chore: theme enhancements #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
previously approved these changes
Jul 2, 2024
rnr
previously approved these changes
Jul 3, 2024
|
@volodymyr-chekyrta Could you spare some time and review it? |
| @@ -61,6 +61,9 @@ struct HandoutsView: View { | |||
| ) | |||
| }) | |||
| Divider() | |||
| .frame(height: 1) | |||
| .overlay(Theme.Colors.cardViewStroke) | |||
| .accessibilityIdentifier("devider") | |||
There was a problem hiding this comment.
typo?
devider -> divider
volodymyr-chekyrta
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new color pallets for customization of styled button in dark mode for better accessibility and course card bg color.
Note: I've set the color in a way that it will not effect the open edX theme and gives the community more ways to configure the app.