-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RTL localization for assets and strings #441
fix: RTL localization for assets and strings #441
Conversation
Thanks for the pull request, @RawanMatar89! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
47fa067
to
7374fb2
Compare
@RawanMatar89 please check the test failures https://github.com/openedx/openedx-app-ios/actions/runs/9204972524/job/25319630671?pr=441
|
@RawanMatar89 please rebase over openedx:develop, resolve conflicts and fix failing tests mentioned in #441 (comment) |
7374fb2
to
d9f1701
Compare
.flipsForRightToLeftLayoutDirection(true) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the extra line here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RawanMatar89. The pull request looks good to me (as a non iOS engineer).
Please mark it as "Ready for review".
@volodymyr-chekyrta kindly triage this PR and let us know if you have any quesations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RawanMatar89 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@RawanMatar89, thank you for your contribution! |
Describtion:
CourseButton
HandoutsView
CourseStructureView
CourseVerticalView
CourseDatesView
DiscussionTopicsView
ProfileSupportInfoView
SettingsView
using "flipsForRightToLeftLayoutDirection" method
Screenshots: