fix for discussion pull to refresh #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-when-refresh chore: get data from API when refresh
forgotvas
approved these changes
Apr 15, 2024
saeedbashir
reviewed
Apr 16, 2024
| @@ -88,19 +90,23 @@ public class ResponsesViewModel: BaseResponsesViewModel, ObservableObject { | |||
| } | |||
|
|
|||
| @MainActor | |||
| func getComments(commentID: String, parentComment: Post, page: Int) async -> Bool { | |||
| func getResponsesData(commentID: String, parentComment: Post, page: Int, refresh: Bool = false) async -> Bool { | |||
There was a problem hiding this comment.
You have renamed the getComments to getResponsesData but there are other elements which are according to the old method name like self.comments. Do we need to update them as well to it's ok to just update the method name?
There was a problem hiding this comment.
I renamed it to getResponsesData because now we get not only the comments here, but also the parent post data - so now it doesn't just work with comments but with several data types.
|
@rnr The code is not compiling at my end and I am getting the following errors. I've tried by cleaning and even by deleting the derived data. |
saeedbashir
approved these changes
Apr 17, 2024
volodymyr-chekyrta
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #358 when after pull-to-refresh user sees 'old' data.
Added actual data retrieval for "parent message" in Thread and Responses Views
Issue recording:
Exported.MPEG-4.movie3.mp4