feat: Calendar Sync Feature Analytics Implementation #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafqat-muneer
force-pushed
the
Shafqat/LEARNER-9888
branch
from
e693263 to
97fb26d
Compare
rnr
previously approved these changes
Apr 5, 2024
saeedbashir
reviewed
Apr 8, 2024
Comment on lines
258
to
293
| public enum EnrollmentMode: String { | ||
| case audit | ||
| case verified | ||
| case none | ||
| } | ||
|
|
||
| public enum Pacing: String { | ||
| case `self` = "self" | ||
| case instructor = "instructor" | ||
| } | ||
|
|
||
| public enum Action: String { | ||
| case on = "on" | ||
| case off = "off" | ||
| case allow = "Allow" | ||
| case doNotAllow = "donot_allow" | ||
| case ok = "OK" | ||
| case cancel = "Cancel" | ||
| case update = "Update" | ||
| case remove = "Remove" | ||
| case done = "Done" | ||
| case viewEvent = "view_event" | ||
| } | ||
|
|
||
| public enum Dialog: String { | ||
| case permission = "Permission" | ||
| case add = "Add" | ||
| case remove = "Remove" | ||
| case update = "Update" | ||
| case confirmed = "Confirmed" | ||
| } | ||
|
|
||
| public enum Snackbar: String { | ||
| case add = "Add" | ||
| case remove = "Remove" | ||
| case update = "Update" |
There was a problem hiding this comment.
It would be nice if you could move this to Course Analytics and also keep all the actions, and stuff in snake case instead of camel case.
|
@saeedbashir Feedback has been addressed. Prepared another review. 🎉 |
rnr
approved these changes
Apr 10, 2024
volodymyr-chekyrta
approved these changes
Apr 10, 2024
saeedbashir
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-9888: Calendar Sync Feature Analytics Implementation
Note:
These analytics additionally necessitate the
EnrollmentModewhich is currently absent incourse_info/blocksAPI. Once this information becomes available, we will address it separately. Currently, I have included this parameter in the Analytics events, but it is being passed asnone.