Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reformat 0001-strategy-for-maintaining-OS-versions.rst #378

Merged
merged 1 commit into from
Mar 28, 2024
Merged

docs: reformat 0001-strategy-for-maintaining-OS-versions.rst #378

merged 1 commit into from
Mar 28, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Mar 27, 2024 •
edited
Loading

@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 27, 2024
brian-smith-tcril
brian-smith-tcril reviewed Mar 27, 2024
View reviewed changes
Copy link

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great formatting changes! Couple tiny notes but this is 99% good to go!

docs/0001-strategy-for-maintaining-OS-versions.rst Outdated
@@ -1,62 +1,68 @@
Title: Strategy for maintaining iOS versions in the OpenEdx Project
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "Title:" here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, now removed.

docs/0001-strategy-for-maintaining-OS-versions.rst Outdated
- Enhanced application security.
- Improved performance and functionality.
- Reduced development and testing burden.
- Implementation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "Implementation" is supposed to be a bullet point, it seems like a heading for the next section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes total sense. Now correct.

@OmarIthawi OmarIthawi changed the base branch from main to develop March 27, 2024 19:40
brian-smith-tcril
brian-smith-tcril reviewed Mar 27, 2024
View reviewed changes
Copy link

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny last thing I didn't catch before.

docs/0001-strategy-for-maintaining-OS-versions.rst Outdated Show resolved Hide resolved
docs/0001-strategy-for-maintaining-OS-versions.rst Outdated Show resolved Hide resolved
@volodymyr-chekyrta volodymyr-chekyrta merged commit 36c0cbd into openedx:develop Mar 28, 2024
3 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmarIthawi @openedx-webhooks @brian-smith-tcril @volodymyr-chekyrta