-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: design team feedback to improve app theming capability #365
chore: design team feedback to improve app theming capability #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding from yesterday's weekly design meeting is that these changes are still not approved, so they can't be merged. |
@volodymyr-chekyrta I believe the design feedback was to bring back the subtitle on the sign-in and register screens. The rest are just theme-based changes that will not affect the open edX build. The new copy of the subtitles is as follows: Sign-in screen: Register screen: Let me know what you think. @marcotuts @sdaitzman @ekangedx what do you guys think of the new subtitles? |
Those new subtitles make sense to me. They're more friendly/welcoming/natural vs. the old copy there. What are the other changes in this PR?
Are there any other changes I'm missing? |
This is already implemented and part of the current codebase.
@sdaitzman This PR adds support for configuring, input text fields, background color, placeholder color, and input text color. The placeholder texts will remain the same for the open edX community. I've added this capability the input background colors for open edX are different for light and dark modes, but for edX its same. |
@volodymyr-chekyrta the subtitles are reverted back and updated with latest text. It's ready for review. |
1 similar comment
@volodymyr-chekyrta the subtitles are reverted back and updated with latest text. It's ready for review. |
@saeedbashir thank you! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@saeedbashir, could you please fix the lint commit error before merge? |
It's happening because of merge branch message and it's bit hard to reword that message, anyhow it will be fixed in squash while merging the PR. |
👍 |
This PR improves the theme capability of the app by introducing more color options. And also, a custom placeholder is added to all the input fields. By adding the custom placeholder, it will help in meeting the a11y requirements.
Note: The rounded and rectangular corners are configurable, via config files.
Visually, the following changes are made to the openedX theme: