feat: implementation / enhancements of analytics #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volodymyr-chekyrta The tests are passing locally but failing on the PR, and I'm not getting any useful insights from the logs. Could you please look into it and see what needs to be fixed. |
rnr
previously approved these changes
Mar 19, 2024
There was a problem hiding this comment.
LGTM
perhaps needs to coordinate with @shafqat-muneer and add analytics for Calendar sync too (maybe after his PR merging?)
|
|
||
| public init(interactor: ProfileInteractorProtocol, router: ProfileRouter, connectivity: ConnectivityProtocol) { | ||
| public init(interactor: ProfileInteractorProtocol, router: ProfileRouter, connectivity: ConnectivityProtocol, analytics: ProfileAnalytics) { |
There was a problem hiding this comment.
please fix line length warning
We have created a separate task for calendar integration events. |
rnr
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds analytics to most parts of the app, as requested by the product team (@moiz994).
Note: @marcotuts We have discussed it internally, and I have renamed the already implemented analytics names for consistency between already implemented and newly implemented analytics, e.g
Forgot_password_ClickedtoLogistration_Forgot_Password_Clicked,Cookie_Policy_ClickedtoProfile_Cookie_Policy_Clicked.