[iOS] UI bug on iPad when using filters in Discussion #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
previously approved these changes
Mar 21, 2024
| .foregroundColor(Theme.Colors.accentXColor) | ||
| Text(viewModel.filterTitle.localizedValue) | ||
| }) | ||
| .confirmationDialog(DiscussionLocalization.Posts.Alert.makeSelection, |
There was a problem hiding this comment.
please follow style "each parameter on own line"
| titleVisibility: isPad ? .automatic : .visible, | ||
| actions: { | ||
| ForEach(viewModel.filterInfos) { info in | ||
| Button(action: { |
There was a problem hiding this comment.
please follow style "each parameter on own line"
| .foregroundColor(Theme.Colors.accentXColor) | ||
| Text(viewModel.sortTitle.localizedValue) | ||
| }) | ||
| .confirmationDialog(DiscussionLocalization.Posts.Alert.makeSelection, |
There was a problem hiding this comment.
please follow style "each parameter on own line"
| titleVisibility: isPad ? .automatic : .visible, | ||
| actions: { | ||
| ForEach(viewModel.sortInfos) { info in | ||
| Button(action: { |
There was a problem hiding this comment.
please follow style "each parameter on own line"
rnr
previously approved these changes
Mar 21, 2024
saeedbashir
reviewed
Mar 22, 2024
| Button( | ||
| action: { | ||
| showFilterSheet = true | ||
| }, |
There was a problem hiding this comment.
Here is extra white space and giving the warning Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace).
| Button( | ||
| action: { | ||
| viewModel.filter(by: info) | ||
| }, |
There was a problem hiding this comment.
Same extra white space warning.
| Button( | ||
| action: { | ||
| showSortSheet = true | ||
| }, |
There was a problem hiding this comment.
Same extra white space warning.
| Button( | ||
| action: { | ||
| viewModel.sort(by: info) | ||
| }, |
There was a problem hiding this comment.
Same extra white space warning.
rnr
approved these changes
Mar 25, 2024
volodymyr-chekyrta
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: [iOS] UI bug on iPad when using filters in Discussion #308
Contains fix for iPad discussions filter and sort sheets