chore: fix branch initialization issue #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
changed the title
volodymyr-chekyrta
approved these changes
Mar 11, 2024
rnr
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed the Branch SDK Integration SDK steps by step. But due to some unknown issues, the latest Branch SDK 3.2.0 isn't working as expected. Even it's not giving initialization call back.
Me and @rnr spent a reasonable amount of time on it and are still not able to figure out why it's not working. The same codebase is working perfectly fine for SDK version 2.2.0.
For the MVP, we don't have the luxury of time to reach out to the branch support team and diagnose the issue. For the time being, I've downgraded the branch SDK to 2.2.0 so we can launch the MVP. We'll look into it post MVP.
Note: We stopped getting an initialization callback for the edX identifier
org.edx.mobile. It works fine for the openedX identifier. The down graded version is working for both edX and openedX identifiers.