-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use custom font and colors across the app where were missing #311
Conversation
…ty can update it via whitelabel script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnr feedback addressed and I've corrected the size of sign-in screen elements |
@saeedbashir please confirm we don't need border for Cancel button here in dark mode |
The screenshot is not accessible. Anyhow, this is just a developer copy of the design so that the app looks presentable in dark mode. We might end up changing the whole color scheme after the design team reviews it. |
OpenEdX/Info.plist
Outdated
<key>UILaunchScreen</key> | ||
<dict> | ||
<key>UIColorName</key> | ||
<string>SplashBackground</string> | ||
<key>UIImageName</key> | ||
<string>appLogo</string> | ||
<key>UIImageRespectsSafeAreaInsets</key> | ||
<true/> | ||
</dict> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance not to replace the LaunchScreen.storyboard
with the Info.plist
configuration?
For some OeX instances we need a slightly more customizable LaunchScreen than just a background color and image, and this would be much easier with a storyboard file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance not to replace the LaunchScreen.storyboard with the Info.plist configuration?
The background color of the storyboard isn't rendered at runtime, and it's selected/applied at selection time. And it's not a good way to parse and change the xml via white-label script to change the colors.
@rnr Is it possible to replace the whole LaunchScreen.storyboard
through a white-label script, so providers can maintain their own LaunchScreen.storyboard
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the white-label script can just remove the Launch screen interface file base name
key from the Info.plist
and add UILaunchScreen
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the whole LaunchScreen.storyboard also an option 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodymyr-chekyrta Yes, we can try both approaches. At first glance, replacing the LaunchScreen.storyboard
file looks easier. @saeedbashir could you please prepare and add this file into edx-mobile-config
repo and I will add whitelabel config and script changes?
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodymyr-chekyrta It's re-added.
At a number of places, the default font was being used for so many elements, and the same was the case for colors. At a number of place, like the
.red
color was used at a number of places instead of the customAlert
color.This PR fixes the issue and enhances the app theme capability by applying the app defined colors and app defined custom fonts across the app.
Note: