Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove entitlement files editing for associated domains from config script #307

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

saeedbashir
Copy link
Contributor

We've added the capability to modify entitlements files on compile time for branch SDK to modify the associated domains depending on the values of the config under the scope of #283.

But modifying the entitlements file on compile time results in very odd issues like not maintaining user sessions across runs, not letting the user login sometimes, etc.

I've removed the entitlements modification part from the config process script. We will review it post MVP and will see whether we will be able to modify entitlements with the whitelabel or not.

@volodymyr-chekyrta
Copy link
Contributor

Let's create a ticket for future research and enhancements

@saeedbashir saeedbashir merged commit 739ec5c into openedx:develop Feb 28, 2024
3 checks passed
@saeedbashir saeedbashir deleted the saeed/entitlements_fix branch February 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants