chore: theme improvements and no handouts handling #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saeedbashir, Could you please add some screenshots for design review? |
rnr
previously approved these changes
Feb 27, 2024
| let handoutsView = handouts != nil && announcements == nil | ||
| let noHandouts = handouts == nil && announcements == nil | ||
|
|
||
| if handoutsView || noHandouts { |
There was a problem hiding this comment.
it appears than this condition can be replaced just with announcements == nil
rnr
approved these changes
Feb 27, 2024
@volodymyr-chekyrta There won't be any design changes for openedX, the changes will only reflect with different color values, for openedX the values are the same. |
volodymyr-chekyrta
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances theme capability by using custom color pellets, giving more breathing space to logo, logo aspect fit, and handles when there aren't any handouts for a course.