Open assessment and Peer instruction tool contents types #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 13, 2024
rnr
previously approved these changes
Feb 13, 2024
saeedbashir
reviewed
Feb 16, 2024
There was a problem hiding this comment.
@forgotvas On the edX codebase we haven't explicitly whitelisted xblock type ubcpi and it's being rendered in the app because of an additional condition. I am unsure how many xblocks will be rendered because of the additional condition. It would be nice if we would mimic the same logic here. The following doing the magic in the edX codebase.
case .Unknown(_), .HTML: return multiDevice ? .HTML(.Base) : .Unknown
volodymyr-chekyrta
previously approved these changes
Feb 19, 2024
regarding to comment openedx#282 (review)
forgotvas
dismissed stale reviews from volodymyr-chekyrta and rnr
via
437274f
@saeedbashir, done |
forgotvas
force-pushed
the
feat/openassessment
branch
from
73216ca to
69eeac9
Compare
rnr
approved these changes
Feb 19, 2024
volodymyr-chekyrta
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR contains: