EULA link and checkbox for "send marketing messages" #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Core/Core.xcodeproj/project.pbxproj
This was
linked to
issues
Feb 2, 2024
eyatsenkoperpetio
requested review from
saeedbashir,
volodymyr-chekyrta and
rnr
rnr
previously approved these changes
Feb 2, 2024
rnr
previously approved these changes
Feb 2, 2024
volodymyr-chekyrta
previously approved these changes
Feb 2, 2024
This was
linked to
issues
Feb 5, 2024
saeedbashir
reviewed
Feb 6, 2024
| case .unknown: | ||
| Text("This field not support") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @ViewBuilder | ||
| private func plaintext(config: FieldConfiguration) -> some View { |
There was a problem hiding this comment.
the config parameter name is conflicting with self.config. How about renaming it to fieldConfig?
saeedbashir
reviewed
Feb 6, 2024
Comment on lines
+88
to
+92
| .onAppear { | ||
| checkBox?.text = "\(sendMarketing)" | ||
| } | ||
| .onChange(of: sendMarketing) { newValue in | ||
| checkBox?.text = "\(newValue)" |
There was a problem hiding this comment.
Any reason to assign boolean text to text of the checkbox? I've commented the code and it was working fine.
saeedbashir
reviewed
Feb 6, 2024
Comment on lines
35
to
39
| .filter { | ||
| $0.field.required && | ||
| !$0.field.isHonorCode && | ||
| $0.field.type != .checkbox | ||
| } |
There was a problem hiding this comment.
Please format it like
fields.filter {
$0.field.required &&
!$0.field.isHonorCode &&
$0.field.type != .checkbox
}
because at other places the same pattern is being used in this file.
saeedbashir
reviewed
Feb 6, 2024
| $0.field.type == .checkbox | ||
| } | ||
| } | ||
| var nonRequiredFields: [FieldConfiguration] { |
There was a problem hiding this comment.
How about renaming it to optionalFields?
saeedbashir
reviewed
Feb 6, 2024
| @@ -12,6 +12,9 @@ | |||
| "SIGN_IN.EMAIL_OR_USERNAME" = "Email or username"; | |||
| "SIGN_IN.PASSWORD" = "Password"; | |||
| "SIGN_IN.FORGOT_PASS_BTN" = "Forgot password?"; | |||
| "SIGN_IN.AGREEMENT" = "By signing in to this app, you agree to the [%@ End User License Agreement](%@) and [%@ Terms of Service and Honor Code](%@) and vou acknowledge that edX and each Member process your personal data in | |||
There was a problem hiding this comment.
type vou it should be you and edX should be replaced platform name from config.
saeedbashir
reviewed
Feb 6, 2024
| @@ -26,6 +29,8 @@ | |||
| "SIGN_UP.SHOW_FIELDS" = "Show optional Fields"; | |||
| "SIGN_UP.SUCCESS_SIGNIN_LABEL" = "You've successfully signed in."; | |||
| "SIGN_UP.SUCCESS_SIGNIN_SUBLABEL" = "We just need a little more information before you start learning."; | |||
| "SIGN_UP.AGREEMENT" = "By creating an account, you agree to the [%@ End User License Agreement](%@) and [%@ Terms of Service and Honor Code](%@) and vou acknowledge that edX and each Member process your personal data inaccordance with the [Privacy Policy.](%@)"; | |||
There was a problem hiding this comment.
saeedbashir
reviewed
Feb 6, 2024
| @@ -12,6 +12,7 @@ private enum AgreementKeys: String { | |||
| case tosURL = "TOS_URL" | |||
| case cookiePolicyURL = "COOKIE_POLICY_URL" | |||
| case dataSellContentURL = "DATA_SELL_CONSENT_URL" | |||
| case eulaURL = "EULA_URL" | |||
There was a problem hiding this comment.
As you are here, could you please make the changes that AgreementKeys implements RawStringExtractable so we have same pattern with all config parsing.
eyatsenkoperpetio
dismissed stale reviews from volodymyr-chekyrta and rnr
via
3970454
saeedbashir
approved these changes
Feb 6, 2024
rnr
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EULA link into the application #230
Add a checkbox for "send marketing messages" on registration page #261
Small UI issues on "Discussions" tab #235
Differences between the FAQ section on the new app and the FAQ section on the market-built app #233