Fix/memory leak #269
Merged
Fix/memory leak #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uality # Conflicts: # Course/Course/SwiftGen/Strings.swift # Course/Course/en.lproj/Localizable.strings # Course/Course/uk.lproj/Localizable.strings
# Conflicts: # Course/Course/Presentation/Outline/ContinueWithView.swift # Profile/Profile.xcodeproj/project.pbxproj
# Conflicts: # Course/Course.xcodeproj/project.pbxproj # Course/Course/Data/CourseRepository.swift
rnr
previously approved these changes
Feb 2, 2024
saeedbashir
reviewed
Feb 2, 2024
| currentProgress(progress, currentSeconds) | ||
| } | ||
| } | ||
|
|
||
| func updateUIViewController(_ playerController: AVPlayerViewController, context: Context) { | ||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
@forgotvas As we are here, how about defining updateUIViewController as @MainActor?
There was a problem hiding this comment.
@saeedbashir to be honestly i don't think that DispatchQueue.main.async required here, because updateUIViewController it's a swiftUI view life cycle method that should guarantee that it will be called from main thread. I will try to test that without dispatch and will commit changes.
There was a problem hiding this comment.
@saeedbashir have removed DispatchQueue.main.async and tested with enabled Main thread checker (enabled by default) and Thread sanitizer diagnostic tools - no problem there.
rnr
approved these changes
Feb 5, 2024
volodymyr-chekyrta
approved these changes
Feb 5, 2024
saeedbashir
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fix for:
RPReplay_Final1705666901.MP4