-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace WhatsNew file with Script #254
Conversation
Lets merge this if it passes |
config_script/whitelabel.py
Outdated
whatsnew_import_file_path: 'path/to/importing/whats_new.json' | ||
project_whatsnew_file_path: 'path/to/json/file/in/project/WhatsNew.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the same patternwhats_new.json
or WhatsNew.json
whatsnew_import_file_path: 'path/to/importing/whats_new.json' # path to what's new json file what should be imported to project | ||
project_whatsnew_file_path: 'path/to/json/file/in/project/WhatsNew.json' # path to existing json-file in project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the same patternwhats_new.json
or WhatsNew.json
@rnr In
In this case, getting following errors by running command:
Suggestion: I think if any configuration is not present then it's related errors should also not come. |
@rnr is it possible to merge this branch with |
The title of the PR can be updated to |
done |
done |
42dd169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
PR for #224
Page hiding is implemented as part of 'theming'
How to test
Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.
From the OpenEdX root folder, run the script as:
Install on your simulator or device
The last page (Learning Site Switching) in What's New will de hidden
Also the
process_config.py
script has been changed, it will now try to merge dictionaries from different files (e.g. iOS.yaml and shared.yaml) if both files have the same section with children in them