Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WhatsNew file with Script #254

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Jan 23, 2024

PR for #224
Page hiding is implemented as part of 'theming'

How to test

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

From the OpenEdX root folder, run the script as:

python config_script/whitelabel.py --config-file=edx-mobile-config/openEdXAssets/whitelabel.yaml -v

Install on your simulator or device

The last page (Learning Site Switching) in What's New will de hidden

Also the process_config.py script has been changed, it will now try to merge dictionaries from different files (e.g. iOS.yaml and shared.yaml) if both files have the same section with children in them

forgotvas
forgotvas previously approved these changes Jan 24, 2024
@touchapp
Copy link

Lets merge this if it passes

Comment on lines 62 to 63
whatsnew_import_file_path: 'path/to/importing/whats_new.json'
project_whatsnew_file_path: 'path/to/json/file/in/project/WhatsNew.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the same patternwhats_new.json or WhatsNew.json

Comment on lines 106 to 107
whatsnew_import_file_path: 'path/to/importing/whats_new.json' # path to what's new json file what should be imported to project
project_whatsnew_file_path: 'path/to/json/file/in/project/WhatsNew.json' # path to existing json-file in project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the same patternwhats_new.json or WhatsNew.json

@shafqat-muneer
Copy link
Contributor

@rnr In whilelabel.yaml file, if I remove all configurations and just place whatsnew related configuration:

whatsnew:
  whatsnew_import_file_path: './edx-mobile-config/openEdXAssets/WhatsNew/whats_new.json'
  project_whatsnew_file_path: './WhatsNew/WhatsNew/Data/WhatsNew.json'

In this case, getting following errors by running command:

python3 config_script/whitelabel.py --config-file=edx-mobile-config/openEdXAssets/whitelabel.yaml -v
Screenshot 2024-01-26 at 2 40 13 PM

Suggestion: I think if any configuration is not present then it's related errors should also not come.

@saeedbashir
Copy link
Contributor

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

@rnr is it possible to merge this branch with saeed/openedX and same in the case of yyatsenko/unit_progress so that we don't need to switch config branches again and again for different features and everyone from Axinite and Touchmedia will have the same copy of data all the time.

@saeedbashir
Copy link
Contributor

The title of the PR can be updated to Replace WhatsNew file with Script or something similar.

@rnr rnr changed the title Whats new page hiding Replace WhatsNew file with Script Jan 26, 2024
@rnr
Copy link
Contributor Author

rnr commented Jan 26, 2024

Clone https://github.com/edx/edx-mobile-config into the OpenEdX root folder and switch to the anton/openedX-theming branch.

@rnr is it possible to merge this branch with saeed/openedX and same in the case of yyatsenko/unit_progress so that we don't need to switch config branches again and again for different features and everyone from Axinite and Touchmedia will have the same copy of data all the time.

done

@rnr
Copy link
Contributor Author

rnr commented Jan 26, 2024

The title of the PR can be updated to Replace WhatsNew file with Script or something similar.

done

@rnr rnr dismissed stale reviews from volodymyr-chekyrta and forgotvas via 42dd169 January 26, 2024 12:42
@rnr rnr requested a review from shafqat-muneer January 26, 2024 12:56
Copy link
Contributor

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rnr rnr merged commit d26f841 into openedx:develop Jan 26, 2024
3 checks passed
@rnr rnr deleted the whats_new_page_hidding branch January 26, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants