Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom user agent to hide app banner on web page #246

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Jan 22, 2024

fix for #220
Added a custom user agent for webView to hide the application banner on a web page

@rnr rnr linked an issue Jan 22, 2024 that may be closed by this pull request
forgotvas
forgotvas previously approved these changes Jan 22, 2024
@rnr rnr changed the title Add custom user agent to hide app banner on web Add custom user agent to hide app banner on web page Jan 22, 2024
@rnr rnr requested a review from forgotvas January 22, 2024 16:20
Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rnr rnr merged commit e4ace45 into openedx:develop Jan 25, 2024
3 checks passed
@rnr rnr deleted the custom_user_agent_for_webview branch January 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] OpenEdX app shows a banner to download edX app
4 participants