Chore: Set Accessibility Identifiers for Startup, Signin. Register, WhatsNew Screens #243
Conversation
| @@ -128,6 +140,7 @@ public struct ResetPasswordView: View { | |||
| .shadowCardStyle(bgColor: Theme.Colors.accentColor, | |||
| textColor: Theme.Colors.white) | |||
| .padding(.top, 80) | |||
| .accessibilityIdentifier("showalert_text") | |||
There was a problem hiding this comment.
Suggestion to replace name with show_alert_text
| @@ -144,6 +157,7 @@ public struct ResetPasswordView: View { | |||
| VStack { | |||
| Spacer() | |||
| SnackBarView(message: viewModel.errorMessage) | |||
| .accessibilityIdentifier("showerror_snackbar") | |||
There was a problem hiding this comment.
Suggestion to replace identifier with show_error_snackbar
| @@ -85,6 +89,7 @@ public struct StartupView: View { | |||
| .font(Theme.Fonts.bodyLarge) | |||
| } | |||
| .padding(.top, isHorizontal ? 0 : 5) | |||
| .accessibilityIdentifier("explorer_courses_button") | |||
There was a problem hiding this comment.
Suggestion to replace identifier with explore_courses_button
| @@ -37,6 +37,7 @@ public struct HTMLFormattedText: UIViewRepresentable { | |||
| textView.textContainerInset = .zero | |||
| textView.textContainer.lineFragmentPadding = 0 | |||
| textView.delegate = context.coordinator | |||
| textView.accessibilityIdentifier = "honer_code_textarea" | |||
There was a problem hiding this comment.
Suggestion to replace identifier with honer_code_text_area
There was a problem hiding this comment.
textarea is used for field type like textfield.
| @@ -41,6 +41,7 @@ public struct WhatsNewView: View { | |||
| .scaledToFit() | |||
| .frame(minWidth: 250, maxWidth: 300) | |||
| .padding(24) | |||
| .accessibilityIdentifier("whatsnew_image") | |||
There was a problem hiding this comment.
Suggestion to replace with whats_new_image
There was a problem hiding this comment.
whatsnew is actually a feature name and pronounced as single entity.
| @@ -124,6 +130,7 @@ public struct WhatsNewView: View { | |||
| .allowsHitTesting(false) | |||
| .padding(.top, isHorizontal ? 0 : 170) | |||
| .padding(.bottom, 8) | |||
| .accessibilityIdentifier("whatsnew_pagecontrol") | |||
There was a problem hiding this comment.
Suggestion to replace with whats_new_page_control
There was a problem hiding this comment.
Here pagecontrol is single entity.
saeedbashir
dismissed stale reviews from volodymyr-chekyrta and rnr
via
96c9bdd
This PR sets accessibility identifiers for startup, signin, forgot password and whats new screens. These accessibility identifiers will be used by the QA team to automate the testing flow.