-
Notifications
You must be signed in to change notification settings - Fork 19
Course bars: Download videos to device and Select download quality bars #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
volodymyr-chekyrta
merged 76 commits into
openedx:develop
from
touchapp:feat/course-download-quality-bars
Feb 1, 2024
Merged
Changes from 74 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
5370d1d
chore: add videos downloading bar view
eyatsenkoperpetio 9e16130
chore: add view and logic
eyatsenkoperpetio 32ad2ea
chore: add progress to download data
eyatsenkoperpetio f88fe44
chore: downloads view
eyatsenkoperpetio 82bb2ff
chore: add strings and fix delete video notif
eyatsenkoperpetio f1d9872
chore: add total progress for bar
eyatsenkoperpetio f191a36
chore: changes for no nested list flow
eyatsenkoperpetio fdca041
fix: showing all downloaded item if open from current course
eyatsenkoperpetio e6a448a
fix: bar progress
eyatsenkoperpetio d2258ef
chore: add large file alert and show all downloads in download view
eyatsenkoperpetio 68b6e17
chore: change logic and remove extra code
eyatsenkoperpetio 4030157
refactor: remove extra code
eyatsenkoperpetio ae7db32
chore: remove extra code
eyatsenkoperpetio 02ccce8
chore: add course storage, refactor
eyatsenkoperpetio 1f40b96
chore: add new video formats
eyatsenkoperpetio ebc81cd
chore: and video to course block
eyatsenkoperpetio 0b1a83e
chore: add new core data models
eyatsenkoperpetio 451ee45
chore: download manager to async await
eyatsenkoperpetio 4b5ea44
chore: add calculate total size download bar
eyatsenkoperpetio 0f8a930
chore: hide total if zero
eyatsenkoperpetio 16b956f
chore: clean up and fix transparent downloads bar when scroll
eyatsenkoperpetio 930b1c8
chore: add new logic check is downloadable video
eyatsenkoperpetio 7e6c218
chore: add download quality view
eyatsenkoperpetio 24983d2
chore: add select quality for download
eyatsenkoperpetio 6d9e3cb
chore: show alert about change download quality when downloading all …
eyatsenkoperpetio a868a69
chore: remove extra and add strings
eyatsenkoperpetio fcdb31d
Merge branch 'feat/166_progress_downloads' into feat/video_download_q…
eyatsenkoperpetio 348b1bc
chore: remove empty line
eyatsenkoperpetio 5257f37
chore: add cancel all download when move to background
eyatsenkoperpetio 23b01a4
Merge branch 'develop' into feat/course_download_quality_bars_dev
eyatsenkoperpetio 269a084
Merge branch 'develop' into feat/course_download_quality_bars_dev
rnr a1f9f1d
chore: add resume downloading
eyatsenkoperpetio f288e68
fix: remaining count in bar
eyatsenkoperpetio d50e4d1
chore: add new logic get quality video
eyatsenkoperpetio acfc9c8
chore: remove extra code
eyatsenkoperpetio c1d65e4
chore: improve download quality names
eyatsenkoperpetio 2f8709a
Merge branch 'feat/course_download_quality_bars' into feat/course_dow…
eyatsenkoperpetio b5761cc
chore: new logic
eyatsenkoperpetio bb69379
chore: update logic
eyatsenkoperpetio a3972ad
chore: remove extra code
eyatsenkoperpetio 02a59d0
chore: remove extra
eyatsenkoperpetio 71460e1
chore: change strings
eyatsenkoperpetio 209c1a0
chore: add string
eyatsenkoperpetio 6298260
chore: show remaining files in download bar
eyatsenkoperpetio 475328e
chore: verticals blocks downloadable count nested list
eyatsenkoperpetio 7b30bf0
chore: count of files
eyatsenkoperpetio 8b7723b
chore: add disable download when offline
eyatsenkoperpetio 86c9d48
chore: remove empty line
eyatsenkoperpetio 5f698fe
chore: show delete file when offline
eyatsenkoperpetio e18a7f1
chore: add Untitled title to download cell view
eyatsenkoperpetio 320daf6
Merge branch 'develop' into feat/course_download_quality_bars_dev_alp…
eyatsenkoperpetio 63512f7
Merge branch 'develop' into feat/course-download-quality-bars
eyatsenkoperpetio 0c3a656
fix: tests
eyatsenkoperpetio 19c3564
chore: PR issues and add accessibility labels
eyatsenkoperpetio 6125d9a
chore: add accessibility identifiers
eyatsenkoperpetio 6b635c2
chore: move video download quality view and refactor
eyatsenkoperpetio 0b16dc6
chore: add cancel all for course
eyatsenkoperpetio 8dc472b
chore: show large alert
eyatsenkoperpetio 50b1649
chore: resolve PR comments
eyatsenkoperpetio ab1792a
chore: resolve PR comments
eyatsenkoperpetio e7c3b61
chore: resolve PR comments
eyatsenkoperpetio ccca6a7
fix: tests
eyatsenkoperpetio fb20cae
chore: resolve PR comments
eyatsenkoperpetio d5f904b
chore: resolve PR commnets
eyatsenkoperpetio 318b1ab
chore: rename DownloadData to DownloadDataTask
eyatsenkoperpetio d4c88cf
chore: use app alert and tests
eyatsenkoperpetio d67ef53
chore: add confirmation alert when deleting video
eyatsenkoperpetio d705e59
chore: remove empty line
eyatsenkoperpetio 57aad7f
chore: add strings
eyatsenkoperpetio baca08c
fix: line length
eyatsenkoperpetio 3c099bf
Merge branch 'develop' into feat/course-download-quality-bars
eyatsenkoperpetio 376368d
Merge branch 'develop' into feat/course-download-quality-bars
eyatsenkoperpetio 81a4512
fix: repeat download
eyatsenkoperpetio 22fa31f
chore: add alert when disable downloading
eyatsenkoperpetio f7f1ad5
chore: resolve PR commnets
eyatsenkoperpetio a64de26
chore: update pod version
eyatsenkoperpetio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
289 changes: 221 additions & 68 deletions
289
Authorization/AuthorizationTests/AuthorizationMock.generated.swift
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
Core/Core/Data/Persistence/CoreDataModel.xcdatamodeld/CoreDataModel.xcdatamodel/contents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use something similar to
CourseDetailEncodedVideoData
here instead of passing all the encodings separately?