Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in browser button is partially hidden in landscape mode #216

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Dec 20, 2023

Small fix for #186 bug
In landscape mode, the screen size is not enough to display the "Open in Browser" button if the content has a title. I've placed this "Unknown" view inside a scroll view.

Screen.Recording.2023-12-20.at.13.59.27.mov

@rnr rnr changed the title Open in browser button is partially hidden in landscape mode#186 Open in browser button is partially hidden in landscape mode Dec 20, 2023
@rnr rnr linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@volodymyr-chekyrta volodymyr-chekyrta merged commit d857e3b into openedx:develop Dec 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] "Open in Browser" button is partially hidden in Landscape mode
3 participants