feat: Update course resume logic, navigate learner to last viewed component #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
requested review from
rnr,
shafqat-muneer and
volodymyr-chekyrta
rnr
previously approved these changes
Dec 15, 2023
| @@ -33,7 +33,7 @@ | |||
| "COURSEWARE.IS_FINISHED" = "“ is finished."; | |||
| "COURSEWARE.CONTINUE" = "Continue"; | |||
| "COURSEWARE.RESUME" = "Resume"; | |||
| "COURSEWARE.CONTINUE_WITH" = "Continue with:"; | |||
| "COURSEWARE.RESUME_WITH" = "Resume with:"; | |||
There was a problem hiding this comment.
@saeedbashir maybe we need to add this to uk.lproj too (even in English) to don't forget to localise this later. What do you think? Thank you
There was a problem hiding this comment.
@rnr Yes, it should be changed in all the relevant files. I've changed it where needed.
| @@ -28,7 +28,7 @@ | |||
| "COURSEWARE.SECTION" = "Section “"; | |||
| "COURSEWARE.IS_FINISHED" = "“ is finished."; | |||
| "COURSEWARE.CONTINUE" = "Continue"; | |||
| "COURSEWARE.CONTINUE_WITH" = "Continue with:"; | |||
| "COURSEWARE.RESUME_WITH" = "Resume with:"; | |||
rnr
approved these changes
Dec 19, 2023
volodymyr-chekyrta
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the course resume logic and navigates the learner to the last visited component screen. The last visited component is being returned from the server for API
/api/mobile/v1/users/\(userName)/course_status_info/\(courseID)Task Link: Remove Sequence units level from Resume action
Screen.Recording.2023-12-15.at.11.52.38.AM.mov