Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add google and microsoft scheme #172

Merged

Conversation

mumer92
Copy link
Contributor

@mumer92 mumer92 commented Nov 23, 2023

This PR updates process_config.py script and updates Google and Microsoft scheme

@volodymyr-chekyrta
Copy link
Contributor

LGTM.
Should we merge it ASAP?

@volodymyr-chekyrta
Copy link
Contributor

Please check if your branch has this commit to run tests 1296cb9

@mumer92
Copy link
Contributor Author

mumer92 commented Nov 24, 2023

@volodymyr-chekyrta i have updated it, and yes we should merge it soon.

@volodymyr-chekyrta
Copy link
Contributor

We need one more review to merge it.
@saeedbashir @rnr @eyatsenkoperpetio Could you take a look?

@volodymyr-chekyrta volodymyr-chekyrta merged commit 7fc5a64 into openedx:develop Nov 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants