chore: course dates feature #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumer92
changed the title
Merged
| @@ -35,6 +35,7 @@ public struct CourseDatesView: View { | |||
| } | |||
| } else if let courseDates = viewModel.courseDates, !courseDates.courseDateBlocks.isEmpty { | |||
| CourseDateListView(viewModel: viewModel, courseDates: courseDates) | |||
| .padding(.top) | |||
There was a problem hiding this comment.
Please set a specific value for .padding(.top).
You might use .padding(.top, 20) as an example.
There was a problem hiding this comment.
@volodymyr-chekyrta i have added padding value to this, but i think this should be handled by the parent or maybe we should handle this by adding NavigationTtile to the child view. This same padding/overlapping issue will occur on the handouts tab.
saeedbashir
reviewed
Nov 7, 2023
Course/CourseTests/Presentation/Unit/CourseDateViewModelTests.swift
Outdated
Show resolved
Hide resolved
saeedbashir
reviewed
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuity of #137
to address feedback, as original PR was merged.
This PR also fixes edge case for the Today block and siblings for Today block, small color fixes to Circle and bit of refactoring.