-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What’s new screen (After Login Experience) #131
What’s new screen (After Login Experience) #131
Conversation
Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
add accessibility support add feature flag to Config
Thank you, these screens look really great!! I only see a few very small potential changes (these are really specific, I don't think they need to be changed to move forward):
I don't think these are important enough to spend a lot of time updating, everything looks good to me! Cross-posting a similar comment here openedx/openedx-app-android#77 |
Hi, @sdaitzman Thanks for your attention to detail, I was fixing it all, could you take a look? Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-26.at.12.04.50.mp4 |
Thanks @IvanStepanok, this all looks great to me! |
change whatsNewEnabled to false
@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Demo:
Screen.Recording.2023-10-19.at.17.30.37.mp4