Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What’s new screen (After Login Experience) #131

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

IvanStepanok
Copy link
Contributor

@IvanStepanok IvanStepanok commented Oct 24, 2023

Demo:

Screen.Recording.2023-10-19.at.17.30.37.mp4

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 24, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@volodymyr-chekyrta volodymyr-chekyrta self-requested a review October 25, 2023 07:02
add accessibility support
add feature flag to Config
@sdaitzman
Copy link

Thank you, these screens look really great!! I only see a few very small potential changes (these are really specific, I don't think they need to be changed to move forward):

  • In the Figma designs, update text is vertically snapped to the bottom, rather than the top underneath the title. I think it looks good either way here, so I just updated the Figma designs to match this.
  • As the "Previous" button appears, can it fade in?

I don't think these are important enough to spend a lot of time updating, everything looks good to me! Cross-posting a similar comment here openedx/openedx-app-android#77

@IvanStepanok
Copy link
Contributor Author

IvanStepanok commented Oct 26, 2023

Hi, @sdaitzman

Thanks for your attention to detail, I was fixing it all, could you take a look?

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-26.at.12.04.50.mp4

@sdaitzman
Copy link

Thanks @IvanStepanok, this all looks great to me!

change whatsNewEnabled to false
@volodymyr-chekyrta volodymyr-chekyrta linked an issue Oct 27, 2023 that may be closed by this pull request
@volodymyr-chekyrta volodymyr-chekyrta linked an issue Oct 27, 2023 that may be closed by this pull request
@volodymyr-chekyrta volodymyr-chekyrta merged commit 6fbe09d into openedx:develop Oct 27, 2023
1 check passed
@openedx-webhooks
Copy link

@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/whatsnew branch October 27, 2023 11:16
@IvanStepanok IvanStepanok restored the feature/whatsnew branch November 3, 2023 10:54
@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/whatsnew branch November 3, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Whats New screens
5 participants