-
Notifications
You must be signed in to change notification settings - Fork 140
build: Upgrade to Node 24 #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade to Node 24 #546
Conversation
|
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
22a89f5 to
9223f3d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 14 14
Lines 82 82
Branches 18 18
=======================================
Hits 78 78
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9223f3d to
b118dcd
Compare
|
Hi @bydawen! Is this pull request still in progress? |
Hello, yes it's still actual, thanks! |
b118dcd to
05c0ee8
Compare
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up! 👍🏼
|
Hi @sarina! This PR is ready to be merge. Can you help with this? |
Description
As a second step in the Node 24 upgrade process, upgrade .nvmrc and regenerate package-lock.json from scratch using Node 24. Also make the Node 24 test a blocking one.
See #542 for further information.