Skip to content

chore: bump eslint - #609

Merged
arbrandes merged 1 commit into
openedx:masterfrom
arbrandes:bump-eslint
Nov 8, 2024
Merged

chore: bump eslint#609
arbrandes merged 1 commit into
openedx:masterfrom
arbrandes:bump-eslint

Conversation

@arbrandes

@arbrandes arbrandes commented Nov 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bump eslint so that we get the new rules that were merged in openedx/eslint-config#164.

@arbrandes arbrandes mentioned this pull request Nov 8, 2024
Merged
@arbrandes
chore: bump eslint
4b7c7e2 
Bump eslint so that we get the new rules that were merged in
openedx/eslint-config#164.
@arbrandes arbrandes mentioned this pull request Nov 8, 2024
Merged
bradenmacdonald
bradenmacdonald approved these changes Nov 8, 2024
View reviewed changes

@bradenmacdonald bradenmacdonald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know why renovate didn't open this PR automatically? Maybe because it was "4.2.0" instead of "^4.2.0" ?

@arbrandes

arbrandes commented Nov 8, 2024

Copy link
Copy Markdown
Contributor Author

@bradenmacdonald, yeah, we were missing the caret. I don't know for sure, but I figure Renovate would respect that.

Anyway, it's conspicuously missing from most other deps as well. I didn't do any prospecting to find out why that is, but I figure at least our internal deps should have it.

@arbrandes
arbrandes merged commit fe27ca5 into openedx:master Nov 8, 2024
@davidjoy

davidjoy commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

Last I knew, Renovate intentionally removes the ^ in an initial PR so that it can fully manage the versions. So... by design, at least as originally implemented in our repos.

@openedx-semantic-release-bot

openedx-semantic-release-bot commented Nov 18, 2024

Copy link
Copy Markdown

🎉 This PR is included in version 14.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

openedx-semantic-release-bot commented Nov 18, 2024

Copy link
Copy Markdown

🎉 This PR is included in version 15.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes
@brian-smith-tcril brian-smith-tcril Awaiting requested review from brian-smith-tcril

Assignees

No one assigned

Labels

released on @alpha released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arbrandes @davidjoy @openedx-semantic-release-bot @bradenmacdonald