Skip to content

Conversation

@ihor-romaniuk
Copy link
Contributor

Description

This merge request contains a height fix to avoid clipping the content of the iframe for discussions sidebar on mobile devices.

Related PR

Screenshots:

Before After
image image

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 3, 2024

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-aurora. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2024
@ihor-romaniuk ihor-romaniuk added backport PR backports a change from main to a named release. and removed open-source-contribution PR author is not from Axim or 2U labels Jun 3, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2024
@codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/redwood.master@d76c0cc). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             open-release/redwood.master    #1404   +/-   ##
==============================================================
  Coverage                               ?   88.81%           
==============================================================
  Files                                  ?      306           
  Lines                                  ?     5256           
  Branches                               ?     1302           
==============================================================
  Hits                                   ?     4668           
  Misses                                 ?      572           
  Partials                               ?       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Jun 6, 2024

@ihor-romaniuk Thank you for your contribution!

Build is green so I'm marking this PR as ready for review.

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Jun 6, 2024
@itsjeyd itsjeyd removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jul 12, 2024
@mariajgrimaldi
Copy link
Member

@brian-smith-tcril, just checking up on this - have you had time to review this PR? Let us know :)

@brian-smith-tcril brian-smith-tcril merged commit 8356505 into openedx:open-release/redwood.master Aug 8, 2024
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 7, 2024
@ihor-romaniuk ihor-romaniuk deleted the romaniuk/fix/iframe-height-for-discussions-sidebar-redwood branch February 3, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants