-
Notifications
You must be signed in to change notification settings - Fork 294
feat: whole course translations #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
91ee3a0
dab0f39
6b62cab
7a46c5e
cc39e9d
a1d9682
9bed3d4
bb01fa0
775911e
30591dc
d07595d
1a1922a
e8e1f70
e4522a5
5c9ccc8
b7f2612
c1879ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import UnitTranslationPlugin from '@plugins/UnitTranslationPlugin'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's great for documentation to have an example plugin defined, but it's unfortunate that we won't be able to leave it pointing to this particular plugin. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we would leave this as an example. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, but let's at least make it clearly fictitious. Or even better, maybe make a skeleton sample plugin that lives in This is not the most urgent bit, though. |
||
| import { PLUGIN_OPERATIONS, DIRECT_PLUGIN } from '@openedx/frontend-plugin-framework'; | ||
|
|
||
| // Load environment variables from .env file | ||
| const config = { | ||
| ...process.env, | ||
| pluginSlots: { | ||
| unit_title_plugin: { | ||
| plugins: [ | ||
| { | ||
| op: PLUGIN_OPERATIONS.Insert, | ||
| widget: { | ||
| id: 'unit_title_plugin', | ||
| type: DIRECT_PLUGIN, | ||
| priority: 1, | ||
| RenderWidget: UnitTranslationPlugin, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default config; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't be able to leave this in
masterfor much longer. See other comments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be move to
env.config.jsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To 2U's own version of it, yes, but preferably not the example one that lives in this repository.