CoursewareContainer tests. - #108
Merged
Merged
Conversation
added 7 commits
July 14, 2020 16:01
… compatible with them.
We need to use it in a few places. Seems worth not-repeating, since they can easily get out of sync. In general, tests should only test the parts of the store they care about, as well.
Ultimately I’d like to move this to frontend-platform as an alternative to ‘initialize’ for tests. ‘initialize’ is an async function which complicates matters.
This removes the need for the snapshot file, and ensures our test is more resilient to unrelated changes in the store. Also added a few more stages of assertions to some of the tests, showing that they have the right values over time.
We can use this in the courseware data tests, and shortly in the tests for CoursewareContainer.
This will help us test sequence navigation’s behavior more fully by having multiple units in a sequence.
2 tasks
davidjoy
force-pushed
the
djoy/courseware-container-tests
branch
from
July 14, 2020 20:25
4f6eecb to
8e36477
Compare
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage ? 54.22%
=========================================
Files ? 108
Lines ? 1219
Branches ? 238
=========================================
Hits ? 661
Misses ? 541
Partials ? 17
Continue to review full report at Codecov.
|
kdmccormick
approved these changes
Jul 14, 2020
kdmccormick
left a comment
kdmccormick
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks for breaking it into commits. Only one piece of feedback.
| expect(container.querySelector('.fake-unit')).toHaveTextContent(unitId); | ||
| }); | ||
|
|
||
| describe('course load denied redirects', () => { |
Member
There was a problem hiding this comment.
Can you improve the describe/it strings for the course load denied redirects tests?
Contributor
Author
There was a problem hiding this comment.
Yes! Thanks. Should have done better on those. ;) Fixed.
Tests loading, sequence navigation/unit rendering, and ‘denied’ states. Subsequent tests will add tests for handlers.
davidjoy
force-pushed
the
djoy/courseware-container-tests
branch
from
July 14, 2020 21:41
8e36477 to
310fd0a
Compare
hopewise
pushed a commit
to zeit-labs/frontend-app-learning
that referenced
this pull request
Sep 27, 2023
…fic-assignment add filter for specific assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit-by-commit. It'll be much easier to understand what's going on.