Skip to content

revert: feat: added bulk delete user posts feature for privileged users - #818

Merged
brian-smith-tcril merged 1 commit into
openedx:masterfrom
kdmccormick:kdmccormick/revert-inf-2029
Sep 29, 2025
Merged

revert: feat: added bulk delete user posts feature for privileged users#818
brian-smith-tcril merged 1 commit into
openedx:masterfrom
kdmccormick:kdmccormick/revert-inf-2029

Conversation

@kdmccormick

@kdmccormick kdmccormick commented Sep 29, 2025

Copy link
Copy Markdown
Member

This reverts commit 909d133.

See openedx/openedx-platform#37402 for details

We leave the original PR's changes to Confirmation.jsx in place because they are fairly reasonable and also because they are tangled in with other recent changes and thus more difficult to revert.

This reverts commit 909d133.

See openedx/openedx-platform#37402 for details

We leave the original PR's changes to Confirmation.jsx in place
because they are OK and are now tangled in with recent changes
and more difficult to revert.
@codecov

codecov Bot commented Sep 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (df53c7c) to head (81684ff).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   94.48%   94.49%   +0.01%     
==========================================
  Files         167      164       -3     
  Lines        3699     3618      -81     
  Branches      999      984      -15     
==========================================
- Hits         3495     3419      -76     
+ Misses        190      185       -5     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kdmccormick

Copy link
Copy Markdown
Member Author

@brian-smith-tcril This is ready to go, can you take a look when you have a sec?

@brian-smith-tcril brian-smith-tcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brian-smith-tcril

Copy link
Copy Markdown
Contributor

We leave the original PR's changes to Confirmation.jsx in place because they are fairly reasonable and also because they are tangled in with other recent changes and thus more difficult to revert.

This seems OK to me assuming the other uses of the Confirmation component have adequate test coverage/have been verified to still work as expected (which seems to have been the case before the original PR landed).

@brian-smith-tcril
brian-smith-tcril merged commit 4d51cf8 into openedx:master Sep 29, 2025
6 checks passed
@kdmccormick
kdmccormick deleted the kdmccormick/revert-inf-2029 branch September 30, 2025 14:10
Alam-2U added a commit to edx/frontend-app-discussions that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants