feat: [FC-86] Not found page and routing refactoring by vladislavkeblysh · Pull Request #4 · openedx/frontend-app-catalog

vladislavkeblysh · 2025-06-01T16:55:28Z

Note

This pull request depends on that PR.

Description

Added Not found page

Added NotFound page component with tests
Updated routing

How Has This Been Tested?

Clone this repository
Check that Not found page is displaying on wrong route ("/some-url" by example)

openedx-webhooks · 2025-06-01T16:55:32Z

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-06-01T16:58:32Z

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (b1a42de) to head (9967150).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/index.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   24.32%   89.09%   +64.76%     
===========================================
  Files           6       10        +4     
  Lines          37       55       +18     
===========================================
+ Hits            9       49       +40     
+ Misses         28        6       -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brian-smith-tcril

Overall this is looking good. Found one problem with the routing tests that I should have noticed earlier that I'd like to address before landing this.

brian-smith-tcril · 2025-06-05T13:37:01Z

        <Route path="/" element={<HomePage />} />
        <Route path="/courses" element={<CatalogPage />} />
        <Route path="/courses/:courseId/about" element={<CourseAboutPage />} />
+        <Route path="*" element={<NotFoundPage />} />


I'm not sure how I didn't catch this when reviewing #3, but having these routes hardcoded into this test file makes them useless. It is 100% possible these tests to pass while index.tsxis routing incorrectly.

routes refactored in next PR

There are now 2 PRs open following this pattern. This is not an acceptable pattern as it does not test anything. I would like to land the PR fixing this first to avoid landing more PRs that follow this pattern.

This still isn't quite where it needs to be. As of 50bee4a the previous describe('App routing' tests have been completely removed.

The goal is to test that components are rendered at the appropriate routes.

Before: There were tests that looked like they were verifying components were rendered at appropriate routes, but the tests were using a router defined in the test file instead of the router in index.jsx.

Now: There are no tests verifying components are rendered at the appropriate routes.

What I want to see: Tests verifying components are rendered at the appropriate routes in the router from index.tsx.

sorry for misunderstanding

Fixed it, please check

ihor-romaniuk · 2025-06-10T13:39:05Z

+import messages from './messages';
+import { render } from '../setupTest';
+
+const renderComponent = () => render(


[nit] I don't think that we will have many test cases here. So we can use render(<NotFoundPage />); directly in test without creating a variable.

ihor-romaniuk · 2025-06-10T13:39:30Z

+import NotFoundPage from './NotFoundPage';
+import messages from './messages';
+import { render } from '../setupTest';


Suggested change

import NotFoundPage from './NotFoundPage';

import messages from './messages';

import { render } from '../setupTest';

import { render } from '../setupTest';

import NotFoundPage from './NotFoundPage';

import messages from './messages';

brian-smith-tcril

Thanks for working through the review process with me! This looks great now!

brian-smith-tcril · 2025-06-11T18:39:54Z

@ihor-romaniuk are you happy with how your review on this has been addressed? If so I'll go ahead and merge it!

ihor-romaniuk · 2025-06-12T06:17:37Z

@brian-smith-tcril LGTM

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 1, 2025

openedx-webhooks added this to Contributions Jun 1, 2025

github-project-automation Bot moved this to Needs Triage in Contributions Jun 1, 2025

vladislavkeblysh requested review from brian-smith-tcril, diana-villalvazo-wgu and peterkulko June 1, 2025 16:55

vladislavkeblysh self-assigned this Jun 1, 2025

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch from ceec09d to b6f8c2b Compare June 1, 2025 16:56

vladislavkeblysh mentioned this pull request Jun 1, 2025

FC-86 feat: Empty page templates #3

Merged

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 3, 2025

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jun 3, 2025

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch from b6f8c2b to 3fdde80 Compare June 4, 2025 08:34

brian-smith-tcril reviewed Jun 5, 2025

View reviewed changes

peterkulko mentioned this pull request Jun 6, 2025

feat: [FC-86] created course list for Catalog page #5

Merged

2 tasks

This was referenced Jun 10, 2025

feat: [FC-86] Home page banner section #7

Merged

feat: [FC-86] Home page courses list #8

Closed

ihor-romaniuk reviewed Jun 10, 2025

View reviewed changes

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch from e933a28 to 8be4e10 Compare June 11, 2025 15:55

vladislavkeblysh requested a review from brian-smith-tcril June 11, 2025 15:56

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch 2 times, most recently from a5e0617 to 4fe977c Compare June 11, 2025 16:33

vladislavkeblysh requested a review from ihor-romaniuk June 11, 2025 16:36

brian-smith-tcril approved these changes Jun 11, 2025

View reviewed changes

diana-villalvazo-wgu approved these changes Jun 11, 2025

View reviewed changes

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch from 4fe977c to 195ba6e Compare June 12, 2025 05:07

ihor-romaniuk approved these changes Jun 12, 2025

View reviewed changes

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch 2 times, most recently from b048e39 to 2d3803a Compare June 12, 2025 07:16

feat: not found page

9967150

vladislavkeblysh force-pushed the keblysh/feat/not-found-page branch from 2d3803a to 9967150 Compare June 12, 2025 07:19

vladislavkeblysh changed the title ~~feat: Not found page~~ feat: Not found page and routing refactoring Jun 12, 2025

peterkulko approved these changes Jun 12, 2025

View reviewed changes

vladislavkeblysh changed the title ~~feat: Not found page and routing refactoring~~ feat: [FC-86] Not found page and routing refactoring Jun 12, 2025

brian-smith-tcril merged commit 3b11900 into openedx:master Jun 12, 2025

github-project-automation Bot moved this from Waiting on Author to Done in Contributions Jun 12, 2025

Uh oh!

Conversation

vladislavkeblysh commented Jun 1, 2025

Description

How Has This Been Tested?

Uh oh!

openedx-webhooks commented Jun 1, 2025

Uh oh!

codecov Bot commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brian-smith-tcril left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril left a comment

Choose a reason for hiding this comment

Uh oh!

brian-smith-tcril commented Jun 11, 2025

Uh oh!

ihor-romaniuk commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Jun 1, 2025 •

edited

Loading