fix: allow page grid to take plugin slot id instead - #994
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 708 708
Lines 12494 12497 +3
Branches 2712 2720 +8
=======================================
+ Hits 11530 11533 +3
Misses 927 927
Partials 37 37 ☔ View full report in Codecov by Sentry. |
leangseu-edx
marked this pull request as ready for review
May 13, 2024 13:33
leangseu-edx
changed the title
KristinAoki
reviewed
May 13, 2024
KristinAoki
approved these changes
May 13, 2024
Contributor
|
@leangseu-edx @KristinAoki we have no idea what this slot does. Could you provide some insight? Why was it added and what could it be used for? For example, this is good documentation for a slot: https://github.com/openedx/frontend-app-authoring/tree/master/src/plugin-slots/CourseAuthoringOutlineSidebarSlot - this slot currently has no documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow
PageGridto take plugin slot id. Because we reused the component, theadditional_plugin_slotshow up twice.TICKET: https://2u-internal.atlassian.net/browse/AU-2022
Supporting information