Skip to content

refactor: remove old taxonomy page route - #954

Merged
xitij2000 merged 1 commit into
openedx:masterfrom
open-craft:rpenido/remove-old-taxonomy-route
Apr 23, 2024
Merged

refactor: remove old taxonomy page route#954
xitij2000 merged 1 commit into
openedx:masterfrom
open-craft:rpenido/remove-old-taxonomy-route

Conversation

@rpenido

@rpenido rpenido commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

This PR removes the redirect from /taxonomy-list (used by Studio at the time) to /taxonomies (new, renamed route).

The change in Studio was made in the following commit:

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 17, 2024
@openedx-webhooks

openedx-webhooks commented Apr 17, 2024

Copy link
Copy Markdown

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido
rpenido force-pushed the rpenido/remove-old-taxonomy-route branch from eac8ae2 to 2be55a0 Compare April 17, 2024 17:59
@codecov

codecov Bot commented Apr 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@0814022). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #954   +/-   ##
=========================================
  Coverage          ?   92.09%           
=========================================
  Files             ?      634           
  Lines             ?    11079           
  Branches          ?     2383           
=========================================
  Hits              ?    10203           
  Misses            ?      847           
  Partials          ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido
rpenido marked this pull request as ready for review April 17, 2024 20:59
@rpenido
rpenido requested a review from a team as a code owner April 17, 2024 20:59

@ChrisChV ChrisChV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good 👍

  • I tested this: I tested that the route is removed
  • I read through the code and considered the security, stability and performance implications of the changes.

@xitij2000
xitij2000 merged commit 7f668a6 into openedx:master Apr 23, 2024
@openedx-webhooks

Copy link
Copy Markdown

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000
xitij2000 deleted the rpenido/remove-old-taxonomy-route branch April 23, 2024 09:22
@bradenmacdonald

Copy link
Copy Markdown
Contributor

Thanks for making this cleanup @rpenido :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants