Display full descendant count on taxonomy tag list page [FC-0036] - #826
Conversation
|
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
26bbd34 to
5672b86
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 545 545
Lines 9585 9585
Branches 2054 2054
=======================================
Hits 8533 8533
Misses 1005 1005
Partials 47 47 ☔ View full report in Codecov by Sentry. |
pomegranited
left a comment
There was a problem hiding this comment.
👍 with one test request.
- I tested this on my devstack with openedx/openedx-core#156
- Navigated to the taxonomies list and selected a taxonomy
- Ensured that the descendant counts are showing as expected next to each tag in the tree.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate.
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
5672b86 to
84d4363
Compare
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thanks @xitij2000 ! |
Implements openedx/modular-learning#191
Depends on openedx/openedx-core#156
This updates the UI to display the total number of descendant tags for each tag, not just the direct number of children.
Private ref: FAL-3655