fix: Fix data API URL handling - #706
Merged
Merged
Conversation
All configuration calls must handled asynchronously, otherwise they risk failure in runtime configuration scenarios.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 446 446
Lines 6851 6851
Branches 1465 1465
=======================================
Hits 6072 6072
Misses 754 754
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Thanks, @brian-smith-tcril! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All configuration calls must handled asynchronously, otherwise they risk failure in runtime configuration scenarios.
To reproduce
The failure is readily reproducible in
tutor localnightly or quince deployments. Simply navigate to a course's "Pages and Resources" page in Studio. The MFE will fail with aUncaught TypeError: URL constructor: course/ is not a valid URL.at src/generic/data/api.js on line 7.The fix
The fix is to make any and all such config assignments into function calls, so that they're resolved just-in-time, as opposed to at initial load time.